[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZRWjVkMYNosNvlt3@yilunxu-OptiPlex-7050>
Date: Fri, 29 Sep 2023 00:01:26 +0800
From: Xu Yilun <yilun.xu@...el.com>
To: Marco Pagani <marpagan@...hat.com>
Cc: Moritz Fischer <mdf@...nel.org>, Wu Hao <hao.wu@...el.com>,
Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org,
linux-fpga@...r.kernel.org
Subject: Re: [PATCH 1/4] fpga: add helpers for the FPGA KUnit test suites.
On 2023-09-26 at 18:39:08 +0200, Marco Pagani wrote:
> Add helpers to facilitate the registration of minimal platform drivers
> to support the parent platform devices used for testing.
>
> Signed-off-by: Marco Pagani <marpagan@...hat.com>
> ---
> drivers/fpga/tests/fpga-test-helpers.h | 29 ++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 drivers/fpga/tests/fpga-test-helpers.h
>
> diff --git a/drivers/fpga/tests/fpga-test-helpers.h b/drivers/fpga/tests/fpga-test-helpers.h
> new file mode 100644
> index 000000000000..fcad3249be68
> --- /dev/null
> +++ b/drivers/fpga/tests/fpga-test-helpers.h
> @@ -0,0 +1,29 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * KUnit test for the FPGA Manager
> + *
> + * Copyright (C) 2023 Red Hat, Inc.
> + *
> + * Author: Marco Pagani <marpagan@...hat.com>
> + */
> +
> +#ifndef FPGA_KUNIT_HELPERS_
> +#define FPGA_KUNIT_HELPERS_
How about _FPGA_KUNIT_HELPERS_H
Others LGTM for this series.
Thanks,
Yilun
> +
> +#define TEST_PDEV_NAME "fpga-test-pdev"
> +
> +#define TEST_PLATFORM_DRIVER(__drv_name) \
> + __TEST_PLATFORM_DRIVER(__drv_name, TEST_PDEV_NAME)
> +/*
> + * Helper macro for defining a minimal platform driver that can
> + * be registered to support the parent platform devices used for
> + * testing.
> + */
> +#define __TEST_PLATFORM_DRIVER(__drv_name, __dev_name) \
> +static struct platform_driver __drv_name = { \
> + .driver = { \
> + .name = __dev_name, \
> + }, \
> +}
> +
> +#endif /* FPGA_KUNIT_HELPERS_ */
> --
> 2.41.0
>
Powered by blists - more mailing lists