linux-kernel - Re: [PATCH v2] fs: simplify misleading code to remove ambiguity regarding ihold()/iput()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230928-zecken-werkvertrag-59ae5e5044de@brauner>
Date:   Thu, 28 Sep 2023 18:21:58 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Luis Henriques <lhenriques@...e.de>
Cc:     Christian Brauner <brauner@...nel.org>,
        Mateusz Guzik <mjguzik@...il.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alexander Viro <viro@...iv.linux.org.uk>,
        David Howells <dhowells@...hat.com>
Subject: Re: [PATCH v2] fs: simplify misleading code to remove ambiguity regarding ihold()/iput()

On Thu, 28 Sep 2023 16:23:41 +0100, Luís Henriques wrote:
> Because 'inode' is being initialised before checking if 'dentry' is negative
> it looks like an extra iput() on 'inode' may happen since the ihold() is
> done only if the dentry is *not* negative.  In reality this doesn't happen
> because d_is_negative() is never true if ->d_inode is NULL.  This patch only
> makes the code easier to understand, as I was initially mislead by it.
> 
> 
> [...]

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/1] fs: simplify misleading code to remove ambiguity regarding ihold()/iput()
      https://git.kernel.org/vfs/vfs/c/5c29bcfaa4cf