linux-kernel - Re: [PATCH][next] wifi: rt2x00: remove redundant check if u8 array element is less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <169591828085.3187104.685774865780206664.kvalo@kernel.org>
Date:   Thu, 28 Sep 2023 16:24:42 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Stanislaw Gruszka <stf_xl@...pl>,
        Helmut Schaa <helmut.schaa@...glemail.com>,
        linux-wireless@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] wifi: rt2x00: remove redundant check if u8 array
 element is less than zero

Colin Ian King <colin.i.king@...il.com> wrote:

> The check on vga_gain[ch_idx] being less than zero is always false since
> vga_gain is a u8 array. Clean up the code by removing the check and the
> following assignment. Cleans up clang scan build warning:
> 
> drivers/net/wireless/ralink/rt2x00/rt2800lib.c:9704:26: warning:
> result of comparison of unsigned expression < 0 is always
> false [-Wtautological-unsigned-zero-compare]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Patch applied to wireless-next.git, thanks.

b2172a9330b5 wifi: rt2x00: remove redundant check if u8 array element is less than zero

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230920121240.120455-1-colin.i.king@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches