linux-kernel - Re: [PATCH] perf record: Fix BTF type checks in the off-cpu profiling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7cjUiet5kNxk=opNrhGgZ2QeqB6J5Tzok5GaEwtgiM-FEA@mail.gmail.com>
Date:   Wed, 27 Sep 2023 20:55:52 -0700
From:   Namhyung Kim <namhyung@...nel.org>
To:     Song Liu <song@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-perf-users@...r.kernel.org, Hao Luo <haoluo@...gle.com>,
        bpf@...r.kernel.org
Subject: Re: [PATCH] perf record: Fix BTF type checks in the off-cpu profiling

On Wed, Sep 27, 2023 at 9:09 AM Song Liu <song@...nel.org> wrote:
>
> On Fri, Sep 22, 2023 at 4:44 PM Namhyung Kim <namhyung@...nel.org> wrote:
> >
> > The BTF func proto for a tracepoint has one more argument than the
> > actual tracepoint function since it has a context argument at the
> > begining.  So it should compare to 5 when the tracepoint has 4
> > arguments.
> >
> >   typedef void (*btf_trace_sched_switch)(void *, bool, struct task_struct *, struct task_struct *, unsigned int);
> >
> > Also, recent change in the perf tool would use a hand-written minimal
> > vmlinux.h to generate BTF in the skeleton.  So it won't have the info
> > of the tracepoint.  Anyway it should use the kernel's vmlinux BTF to
> > check the type in the kernel.
> >
> > Fixes: b36888f71c85 ("perf record: Handle argument change in sched_switch")
> > Cc: Song Liu <song@...nel.org>
> > Cc: Hao Luo <haoluo@...gle.com>
> > CC: bpf@...r.kernel.org
> > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
>
> Acked-by: Song Liu <song@...nel.org>

Applied to perf-tools-next, thanks!