linux-kernel - Re: [PATCH 1/2] input: generalize the Imagis touchscreen driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Sep 2023 20:07:04 +0200
From:   "Karel Balej" <karelb@...li.ms.mff.cuni.cz>
To:     "Markuss Broks" <markuss.broks@...il.com>,
        "Karel Balej" <balejk@...fyz.cz>
Cc:     "Dmitry Torokhov" <dmitry.torokhov@...il.com>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        "Conor Dooley" <conor+dt@...nel.org>,
        <linux-input@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Duje Mihanović <duje.mihanovic@...le.hr>,
        <~postmarketos/upstreaming@...ts.sr.ht>,
        "Jeff LaBundy" <jeff@...undy.com>, <linmengbo0689@...tonmail.com>
Subject: Re: [PATCH 1/2] input: generalize the Imagis touchscreen driver

Hello, Markuss,

thank you for your response and please forgive that my original emails
didn't reach you - I am trying to see if I can get the SMTP server I use
for my primary address officially authorized to send emails in its name
so that Google does not reject them.

> To be fair, this driver should work with all Imagis3 chips, which could 
> be a better name for it. However, I agree with Jeff here: the driver 
> doesn't necessarily need renaming.

I will be sure to drop the renaming for v2.

> Additionally, there used to be my series [1] that generalized the 
> driver, but it never got applied. I will re-send it. It introduces 
> `struct imagis_properties`, which contains register addresses for the 
> registers that we use to read the touch input. In your specific case, I 
> believe it should be:
>
> static const struct imagis_properties imagis_3032c_data =
> {
> 	.interrupt_msg_cmd = IST3038C_REG_INTR_MESSAGE,
> 	.touch_coord_cmd = IST3038C_REG_TOUCH_COORD,
> 	.whoami_cmd = IST3038C_REG_CHIPID,
> 	.whoami_val = IST3032C_WHOAMI, /* change it to your whoami */
> };

I have come across your patch series and in fact my original experiments
were based on it. However I thought it was abandoned and decided not to
try to make any further generalizations to the driver for now, except
making it work with IST3032C. Should I then perhaps wait before your
series gets applied before sending v2 of my changes? Or should I send
you a patch on top of your series, where I would add the `struct
imagis_properties` for the IST3032C (which you surely could do yourself,
but I can at least test it with my device). Please let me know if and
how we should coordinate.

> As for the voltage set, I believe this does not belong in a kernel 
> driver. You should set it in device-tree with `regulator-max-microvolt` 
> and `regulator-min-microvolt`.

Please see my response to Jeff regarding this. I will be happy to hear
your thoughts on what I propose.

Kind regards,
K. B.