linux-kernel - Re: [PATCH] serial: 8250_omap: Drop pm_runtime_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 Sep 2023 02:11:40 +0800
From:   kernel test robot <lkp@...el.com>
To:     Tony Lindgren <tony@...mide.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Andy Shevchenko <andriy.shevchenko@...el.com>,
        Dhruva Gole <d-gole@...com>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        John Ogness <john.ogness@...utronix.de>,
        Johan Hovold <johan@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] serial: 8250_omap: Drop pm_runtime_irq_safe()

Hi Tony,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tty/tty-testing]
[also build test WARNING on tty/tty-next tty/tty-linus usb/usb-testing usb/usb-next usb/usb-linus linus/master v6.6-rc3 next-20230928]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Tony-Lindgren/serial-8250_omap-Drop-pm_runtime_irq_safe/20230928-160501
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link:    https://lore.kernel.org/r/20230928080358.2693-1-tony%40atomide.com
patch subject: [PATCH] serial: 8250_omap: Drop pm_runtime_irq_safe()
config: sh-allyesconfig (https://download.01.org/0day-ci/archive/20230929/202309290255.uEGVqQAE-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230929/202309290255.uEGVqQAE-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309290255.uEGVqQAE-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/tty/serial/8250/8250_omap.c: In function 'omap8250_irq':
>> drivers/tty/serial/8250/8250_omap.c:688:1: warning: label 'out_runtime_put' defined but not used [-Wunused-label]
     688 | out_runtime_put:
         | ^~~~~~~~~~~~~~~


vim +/out_runtime_put +688 drivers/tty/serial/8250/8250_omap.c

   651	
   652		lsr = serial_port_in(port, UART_LSR);
   653		iir = serial_port_in(port, UART_IIR);
   654		ret = serial8250_handle_irq(port, iir);
   655	
   656		/*
   657		 * On K3 SoCs, it is observed that RX TIMEOUT is signalled after
   658		 * FIFO has been drained, in which case a dummy read of RX FIFO
   659		 * is required to clear RX TIMEOUT condition.
   660		 */
   661		if (priv->habit & UART_RX_TIMEOUT_QUIRK &&
   662		    (iir & UART_IIR_RX_TIMEOUT) == UART_IIR_RX_TIMEOUT &&
   663		    serial_port_in(port, UART_OMAP_RX_LVL) == 0) {
   664			serial_port_in(port, UART_RX);
   665		}
   666	
   667		/* Stop processing interrupts on input overrun */
   668		if ((lsr & UART_LSR_OE) && up->overrun_backoff_time_ms > 0) {
   669			unsigned long delay;
   670	
   671			/* Synchronize UART_IER access against the console. */
   672			uart_port_lock(port);
   673			up->ier = port->serial_in(port, UART_IER);
   674			if (up->ier & (UART_IER_RLSI | UART_IER_RDI)) {
   675				port->ops->stop_rx(port);
   676			} else {
   677				/* Keep restarting the timer until
   678				 * the input overrun subsides.
   679				 */
   680				cancel_delayed_work(&up->overrun_backoff);
   681			}
   682			uart_port_unlock(port);
   683	
   684			delay = msecs_to_jiffies(up->overrun_backoff_time_ms);
   685			schedule_delayed_work(&up->overrun_backoff, delay);
   686		}
   687	
 > 688	out_runtime_put:
   689		pm_runtime_mark_last_busy(port->dev);
   690		pm_runtime_put(port->dev);
   691	
   692		return IRQ_RETVAL(ret);
   693	}
   694	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki