[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230928133814.szn5dd4gzshmccia@mercury.elektranox.org>
Date: Thu, 28 Sep 2023 15:38:14 +0200
From: Sebastian Reichel <sre@...nel.org>
To: Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Johan Hovold <johan@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] power: supply: qcom_battmgr: fix battery_id type
+cc Johan Hovold who gave away that he is involved with this at
Kernel Recipes :)
On Tue, Sep 19, 2023 at 02:42:22PM +0200, Sebastian Reichel wrote:
> qcom_battmgr_update_request.battery_id is written to using cpu_to_le32()
> and should be of type __le32, just like all other 32bit integer requests
> for qcom_battmgr.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202309162149.4owm9iXc-lkp@intel.com/
> Fixes: 29e8142b5623 ("power: supply: Introduce Qualcomm PMIC GLINK power supply")
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> ---
> drivers/power/supply/qcom_battmgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c
> index de77df97b3a4..a05fd00711f6 100644
> --- a/drivers/power/supply/qcom_battmgr.c
> +++ b/drivers/power/supply/qcom_battmgr.c
> @@ -105,7 +105,7 @@ struct qcom_battmgr_property_request {
>
> struct qcom_battmgr_update_request {
> struct pmic_glink_hdr hdr;
> - u32 battery_id;
> + __le32 battery_id;
> };
>
> struct qcom_battmgr_charge_time_request {
> --
> 2.40.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists