linux-kernel - Re: [PATCH] ARM: dts: omap4-embt2ws: Add Bluetooth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 Sep 2023 06:54:59 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Andreas Kemnade <andreas@...nade.info>
Cc:     bcousson@...libre.com, tony@...mide.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: omap4-embt2ws: Add Bluetooth

On 27/09/2023 18:29, Andreas Kemnade wrote:
> 
> 
> On Wed, 27 Sep 2023 09:56:28 +02Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> 
>> On 26/09/2023 22:42, Andreas Kemnade wrote:
>>> Since the required clock is now available, add bluetooth.
>>>
>>> Note: Firmware (bts file) from device vendor reroutes tx for some time
>>> during initialisation and later put it back, producing timeouts in
>>> bluetooth initialisation but ignoring that command leads to proper
>>> initialisation.
>>>
>>> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
>>> ---
>>> Depends on: https://lore.kernel.org/linux-omap/20230916100515.1650336-6-andreas@kemnade.info/T/#u
>>>  arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 10 ++++++----
>>>  1 file changed, 6 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
>>> index 9d2f2d8639496..25b80385dc1f0 100644
>>> --- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
>>> +++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
>>> @@ -478,10 +478,12 @@ &uart2 {
>>>  	interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH
>>>  			       &omap4_pmx_core OMAP4_UART2_RX>;
>>>  
>>> -	/*
>>> -	 * BT + GPS in WL1283 in WG7500 requiring CLK32KAUDIO of pmic
>>> -	 * which does not have a driver
>>> -	 */
>>> +	bluetooth: tiwi {  
>>
>> Node names should be generic. See also an explanation and list of
>> examples (not exhaustive) in DT specification:
>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>>
>> E.g. "bluetooth"
>>
> well, that is what I get currently as a reward from the kernel for describing
> the hardware and so the motivation for the patch, not necessarily the most important
> functionality.
> 
> But the over the uart runs the ti shared transport protocol (also there is
> a non dt compatible driver in drivers/misc/ti-st) which provides more than Bluetooth,
> e.g. it also provides at least GNSS and FM (although it do not know if it works in this particular
> hardware). GPS/GNSS should work.
> 
> So the node name would be bluetoothgnss then? Well, I think we do not need the label then.

bluetooth-gnss would work for me if it was accepted by bindings... but
it is not, so this leaves you so far with "bluetooth".

Best regards,
Krzysztof