linux-kernel - Re: [PATCH v2 0/2] get_maintainer: add patch-only keyword matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFhGd8rtnvipRVAKRQAEcyGqCknVmx+bd2NMT7mCuTZjhrqULA@mail.gmail.com>
Date:   Thu, 28 Sep 2023 14:31:17 +0900
From:   Justin Stitt <justinstitt@...gle.com>
To:     Joe Perches <joe@...ches.com>
Cc:     linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        geert@...ux-m68k.org, gregkh@...uxfoundation.org,
        workflows@...r.kernel.org, mario.limonciello@....com
Subject: Re: [PATCH v2 0/2] get_maintainer: add patch-only keyword matching

On Thu, Sep 28, 2023 at 2:01 PM Joe Perches <joe@...ches.com> wrote:
>
> On Thu, 2023-09-28 at 04:23 +0000, Justin Stitt wrote:
> > Changes in v2:
> > - remove formatting pass (thanks Joe) (but seriously the formatting is
> >   bad, is there opportunity to get a formatting pass in here at some
> >   point?)
>
> Why?  What is it that makes you believe the formatting is bad?
>

Investigating further, it looked especially bad in my editor. There is
a mixture of
tabs and spaces and my vim tabstop is set to 4 for pl files. Setting this to
8 is a whole lot better. But I still see some weird spacing.

Some lines start with a bunch of spaces, other lines start with a tab character.
This interleaving of tabs and spaces to start lines makes some editor configs
render it weirdly.

Notice how any .c file in the kernel only starts with tabs and thus is rendered
consistently.

ctrl+f for "\t" and see that some lines are tabbed and others are not.
I attached a screenshot to this email showing this.

However, now that I understand the issue more clearly this is definitely
not as big an issue as I thought.

Download attachment "Screenshot 2023-09-28 2.24.19 PM.png" of type "image/png" (136813 bytes)