linux-kernel - Re: [PATCH v3 06/11] dt-bindings: timer: Add Sophgo sg2042 CLINT timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230928-bring-gnarly-05eeeb85f3c5@wendy>
Date:   Thu, 28 Sep 2023 07:27:09 +0100
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Inochi Amaoto <inochiama@...look.com>
CC:     Conor Dooley <conor@...nel.org>, <aou@...s.berkeley.edu>,
        <chao.wei@...hgo.com>, <devicetree@...r.kernel.org>,
        <emil.renner.berthing@...onical.com>, <guoren@...nel.org>,
        <jszhang@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <linux-kernel@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
        <palmer@...belt.com>, <paul.walmsley@...ive.com>,
        <robh+dt@...nel.org>, <xiaoguang.xing@...hgo.com>,
        Anup Patel <apatel@...tanamicro.com>,
        Chen Wang <wangchen20@...as.ac.cn>
Subject: Re: [PATCH v3 06/11] dt-bindings: timer: Add Sophgo sg2042 CLINT
 timer

On Thu, Sep 28, 2023 at 08:34:42AM +0800, Inochi Amaoto wrote:

> >> +properties:
> >> +  compatible:
> >> +    oneOf:
> >> +      - items:
> >> +          - const: sophgo,sg2042-clint-mtimer
> >
> >There's only one of these, so you don't need the oneOf.
> 
> Thanks
> 
> >Also, is the clint here not a thead IP? In which case, you need to add a
> 
> Yes, The clint is a thead IP, like that of th1520 and allwinner D1.
> 
> >second compatible IMO. That second compatible then would be the one that
> >appears in opensbi etc.
> >
> 
> As this is a thead IP, maybe use thead,c900-clint-mtimer is fine?

I would suggest calling it -aclint-mtimer instead of clint-mtimer.

> If so, whether we should replace the "thead,c900-clint" with these separate
> DT to describe the thead clint?

No, since that's a different device, right?

> The DT binding said the thead clint is not
> compatible with the sifive clint, so maybe this is a chance to just move
> them out.

I don't think that it really makes sense to do that.

Thanks,
Conor.


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)