linux-kernel - Re: [PATCH] md: use interruptible apis in idle/frozen_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <382b6c81-598b-52be-c09a-2f5b293b8d69@huaweicloud.com>
Date:   Thu, 28 Sep 2023 14:31:41 +0800
From:   Yu Kuai <yukuai1@...weicloud.com>
To:     Song Liu <song@...nel.org>, Yu Kuai <yukuai1@...weicloud.com>
Cc:     Li Nan <linan122@...wei.com>, linux-raid@...r.kernel.org,
        linux-kernel@...r.kernel.org, yi.zhang@...wei.com,
        houtao1@...wei.com, yangerkun@...wei.com,
        "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH] md: use interruptible apis in idle/frozen_sync_thread

Hi,

在 2023/09/09 4:29, Song Liu 写道:
> On Wed, Sep 6, 2023 at 11:31 PM Yu Kuai <yukuai1@...weicloud.com> wrote:
>>
>> 在 2023/09/06 16:44, Li Nan 写道:
>>> Before refactoring idle and frozen from action_store, interruptible apis
>>> is used so that hungtask warning won't be triggered if it takes too long
>>> to finish indle/frozen sync_thread. So change to use interruptible apis.
>>>
>> LGTM
>>
>> Reviewed-by: Yu Kuai <yukuai3@...wei.com>
>>
>>> Signed-off-by: Li Nan <linan122@...wei.com>
> 
> I think we will need a fix tag and send this via md-fixes branch (to 6.6)?
> 

I agree, Nan, please resend this patch.

Thanks,
Kuai

> Thanks,
> Song
> 
> 
> 
>>> ---
>>>    drivers/md/md.c | 13 +++++++++----
>>>    1 file changed, 9 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/md/md.c b/drivers/md/md.c
>>> index 46badd13a687..52689adfa37f 100644
>>> --- a/drivers/md/md.c
>>> +++ b/drivers/md/md.c
>>> @@ -4834,11 +4834,14 @@ static void idle_sync_thread(struct mddev *mddev)
>>>    {
>>>        int sync_seq = atomic_read(&mddev->sync_seq);
>>>
>>> -     mutex_lock(&mddev->sync_mutex);
>>> +     if (mutex_lock_interruptible(&mddev->sync_mutex))
>>> +             return;
>>> +
>>>        clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
>>>        stop_sync_thread(mddev);
>>>
>>> -     wait_event(resync_wait, sync_seq != atomic_read(&mddev->sync_seq) ||
>>> +     wait_event_interruptible(resync_wait,
>>> +                     sync_seq != atomic_read(&mddev->sync_seq) ||
>>>                        !test_bit(MD_RECOVERY_RUNNING, &mddev->recovery));
>>>
>>>        mutex_unlock(&mddev->sync_mutex);
>>> @@ -4846,11 +4849,13 @@ static void idle_sync_thread(struct mddev *mddev)
>>>
>>>    static void frozen_sync_thread(struct mddev *mddev)
>>>    {
>>> -     mutex_lock(&mddev->sync_mutex);
>>> +     if (mutex_lock_interruptible(&mddev->sync_mutex))
>>> +             return;
>>> +
>>>        set_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
>>>        stop_sync_thread(mddev);
>>>
>>> -     wait_event(resync_wait, mddev->sync_thread == NULL &&
>>> +     wait_event_interruptible(resync_wait, mddev->sync_thread == NULL &&
>>>                        !test_bit(MD_RECOVERY_RUNNING, &mddev->recovery));
>>>
>>>        mutex_unlock(&mddev->sync_mutex);
>>>
>>
> .
>