linux-kernel - Re: [PATCH] hte: allow building modules with COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Sep 2023 08:53:28 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Dipen Patel <dipenp@...dia.com>
Cc:     timestamp@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] hte: allow building modules with COMPILE_TEST enabled

On Thu, Sep 28, 2023 at 5:31 AM Dipen Patel <dipenp@...dia.com> wrote:
>
> On 9/25/23 1:37 AM, Bartosz Golaszewski wrote:
> > On Mon, Sep 11, 2023 at 11:46 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> >>
> >> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >>
> >> Allow building all HTE modules with COMPILE_TEST Kconfig option enabled.
> >>
> >> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> >> ---
> >> This was part of a wider series but since this is independent, I'm sending
> >> it separately.
> >>
> >>  drivers/hte/Kconfig | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/hte/Kconfig b/drivers/hte/Kconfig
> >> index cf29e0218bae..083e67492bf2 100644
> >> --- a/drivers/hte/Kconfig
> >> +++ b/drivers/hte/Kconfig
> >> @@ -16,7 +16,7 @@ if HTE
> >>
> >>  config HTE_TEGRA194
> >>         tristate "NVIDIA Tegra194 HTE Support"
> >> -       depends on ARCH_TEGRA_194_SOC
> >> +       depends on (ARCH_TEGRA_194_SOC || COMPILE_TEST)
> >>         help
> >>           Enable this option for integrated hardware timestamping engine also
> >>           known as generic timestamping engine (GTE) support on NVIDIA Tegra194
> >> @@ -25,7 +25,7 @@ config HTE_TEGRA194
> >>
> >>  config HTE_TEGRA194_TEST
> >>          tristate "NVIDIA Tegra194 HTE Test"
> >> -        depends on HTE_TEGRA194
> >> +        depends on (HTE_TEGRA194 || COMPILE_TEST)
> >>          help
> >>           The NVIDIA Tegra194 GTE test driver demonstrates how to use HTE
> >>           framework to timestamp GPIO and LIC IRQ lines.
> >> --
> >> 2.39.2
> >>
> >
> > Hi Dipen!
> >
> > Any comments on this, the other patch with a comment update as well as
> > the one addressing usage of gpiochip_find() in HTE drivers?
> Sorry for the late response, This looks good to me. I will review and test
> rest other patches.
>
> >
> > Bart
> Acked-by: Dipen Patel <dipenp@...dia.com>

Do you want me to take it through the GPIO tree or your own? Either
way no GPIO patches depend on it.

Bart