linux-kernel - Re: [PATCH] phy: realtek: Realtek PHYs should depend on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWor=u72E_ZfERyH3dUw3r0dsd43VsVTkx2w+DiJvyLGA@mail.gmail.com>
Date:   Thu, 28 Sep 2023 09:56:16 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Stanley Chang[昌育德] 
        <stanley_chang@...ltek.com>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK

Hi Vinod,

On Thu, Aug 17, 2023 at 8:46 AM Vinod Koul <vkoul@...nel.org> wrote:
> On 17-08-23, 02:06, Stanley Chang[昌育德] wrote:
> > > diff --git a/drivers/phy/realtek/Kconfig b/drivers/phy/realtek/Kconfig index
> > > 650e20ed69af41d2..75ac7e7c31aec6f2 100644
> > > --- a/drivers/phy/realtek/Kconfig
> > > +++ b/drivers/phy/realtek/Kconfig
> > > @@ -2,6 +2,9 @@
> > >  #
> > >  # Phy drivers for Realtek platforms
> > >  #
> > > +
> > > +if ARCH_REALTEK || COMPILE_TEST
> > > +
> > >  config PHY_RTK_RTD_USB2PHY
> > >         tristate "Realtek RTD USB2 PHY Transceiver Driver"
> > >         depends on USB_SUPPORT
> > > @@ -25,3 +28,5 @@ config PHY_RTK_RTD_USB3PHY
> > >           The DHC (digital home center) RTD series SoCs used the Synopsys
> > >           DWC3 USB IP. This driver will do the PHY initialization
> > >           of the parameters.
> > > +
> > > +endif # ARCH_REALTEK || COMPILE_TEST
> >
> > Thanks for your patch.
> > Why not use "depends on"?
> > depends on ARCH_MEDIATEK || COMPILE_TEST
>
> I think this patch is better, this way all future rtek drivers will be
> fixed as well, no need to add for each driver

Is there anything still blocking this patch?
Do you want me to resend?
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds