linux-kernel - Re: [PATH v3 2/3] iommu/vt-d: debugfs: Create/remove debugfs file per {device, pasid}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f250db59-03aa-3a64-3bb7-08fbcbf41839@linux.intel.com>
Date:   Thu, 28 Sep 2023 17:17:08 +0800
From:   Baolu Lu <baolu.lu@...ux.intel.com>
To:     "Liu, Jingqi" <jingqi.liu@...el.com>, iommu@...ts.linux.dev,
        Tian Kevin <kevin.tian@...el.com>,
        Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>
Cc:     baolu.lu@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATH v3 2/3] iommu/vt-d: debugfs: Create/remove debugfs file per
 {device, pasid}

On 2023/9/28 17:02, Liu, Jingqi wrote:
>> And here,
>>
>> void intel_iommu_debugfs_create_dev_pasid(struct iommu_domain *domain,
>>                       struct device *dev, u32 pasid)
>> {
>>     sprintf(dir_name, "%x", pasid);
>>     dev_pasid->debugfs_entry = debugfs_create_dir(dir_name,
>>             info->debugfs_entry);
>>
>>     debugfs_create_file("domain_translation_struct", 0444,
>>                 dev_pasid->debugfs_entry, dev_pasid,
>>                 &domain_translation_struct_fops);
>> }
>>
> Thanks.
> You mean to add 'debugfs_entry' in below structure.
>      struct dev_pasid_info *dev_pasid;
> This structure is also allocated per pair of {dev, pasid}.
> The debugfs dentry of  {dev, pasid} can be simply obtained from 
> 'dev_pasid_info'.
> 
> So the 'dev_pasid_info' can be passed as a parameter of this helper, 
> right ?
> Like this:
> void intel_iommu_debugfs_create_dev_pasid(struct iommu_domain *domain,
>                        struct dev_pasid_info *dev_pasid) ;

Yes.

Best regards,
baolu