linux-kernel - RE: Re: [PATCH] crypto: virtio-crypto: call finalize with bh disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53d400c057564aa28930bbf3d76ddeff@huawei.com>
Date:   Thu, 28 Sep 2023 02:03:18 +0000
From:   "Gonglei (Arei)" <arei.gonglei@...wei.com>
To:     zhenwei pi <pizhenwei@...edance.com>,
        "Michael S. Tsirkin" <mst@...hat.com>
CC:     Halil Pasic <pasic@...ux.ibm.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        Marc Hartmayer <mhartmay@...ux.ibm.com>,
        Jason Wang <jasowang@...hat.com>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Cornelia Huck <cohuck@...hat.com>
Subject: RE: Re: [PATCH] crypto: virtio-crypto: call finalize with bh disabled



> -----Original Message-----
> From: zhenwei pi [mailto:pizhenwei@...edance.com]
> Sent: Thursday, September 28, 2023 9:24 AM
> To: Michael S. Tsirkin <mst@...hat.com>; Gonglei (Arei)
> <arei.gonglei@...wei.com>
> Cc: Halil Pasic <pasic@...ux.ibm.com>; Herbert Xu
> <herbert@...dor.apana.org.au>; linux-crypto@...r.kernel.org; Marc
> Hartmayer <mhartmay@...ux.ibm.com>; Jason Wang
> <jasowang@...hat.com>; virtualization@...ts.linux-foundation.org;
> linux-kernel@...r.kernel.org; Cornelia Huck <cohuck@...hat.com>
> Subject: Re: Re: [PATCH] crypto: virtio-crypto: call finalize with bh disabled
> 
> Hi Michael & Lei,
> 
> I volunteer to fix this by workqueue.
> 
Thanks, patches are always welcome.

> I also notice that device drivers use workqueue to handle config-changed again
> and again, what about re-implement __virtio_config_changed() by kicking
> workqueue instead?
> 
Personally, I prefer to implement it in the device driver case by case. some devices 
want to work in the upper half of the interrupt context, such as virtio-mem.

> By the way, balloon dirvers uses
> spin_lock_irqsave/spin_unlock_irqrestore in config-changed callback, do it
> handle correctly?
> 
It's ok. The critical resource protected is global system_freezable_wq.

Regards,
-Gonglei

> On 9/27/23 21:25, Halil Pasic wrote:
> > On Wed, 27 Sep 2023 09:24:09 +0000
> > "Gonglei (Arei)" <arei.gonglei@...wei.com> wrote:
> >
> >>> On a related note, config change callback is also handled
> >>> incorrectly in this driver, it takes a mutex from interrupt context.
> >>
> >> Good catch. Will fix it.
> >
> > Thanks Gonglei! Sorry I first misunderstood this as a problem within
> > the virtio-ccw driver, but it is actually about virtio-crypto. Thanks
> > for fixing this!
> >
> > Regards,
> > Halil
> 
> --
> zhenwei pi