linux-kernel - [PATCH 4/5] pstore: remove the module parameter "backend"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Sep 2023 10:42:43 +0800
From:   Yuanhe Shu <xiangzao@...ux.alibaba.com>
To:     gregkh@...uxfoundation.org, jirislaby@...nel.org,
        keescook@...omium.org, tony.luck@...el.com, gpiccoli@...lia.com,
        shuah@...nel.org
Cc:     linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-hardening@...r.kernel.org, linux-kselftest@...r.kernel.org,
        Yuanhe Shu <xiangzao@...ux.alibaba.com>,
        Xingrui Yi <yixingrui@...ux.alibaba.com>
Subject: [PATCH 4/5] pstore: remove the module parameter "backend"

Since all enabled backends have corresponding subdir in
/sys/fs/pstore, and the logic of finding unexpected is
changed by using psinfo_list rather than parameter backend,
it is not necessary to retain the parameter backend.

Remove the unnecessary module parameter "backend".

Signed-off-by: Xingrui Yi <yixingrui@...ux.alibaba.com>
Signed-off-by: Yuanhe Shu <xiangzao@...ux.alibaba.com>
---
 fs/pstore/platform.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index d576ee48527c..90c33c1ca39f 100644
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@ -77,10 +77,6 @@ static DECLARE_WORK(pstore_work, pstore_dowork);
 DEFINE_MUTEX(psback_lock);
 struct pstore_backends *psback;
 
-static char *backend;
-module_param(backend, charp, 0444);
-MODULE_PARM_DESC(backend, "specific backend to use");
-
 static char *compress =
 #ifdef CONFIG_PSTORE_COMPRESS_DEFAULT
 		CONFIG_PSTORE_COMPRESS_DEFAULT;
@@ -675,12 +671,6 @@ int pstore_register(struct pstore_info *psi)
 	/* Start watching for new records, if desired. */
 	pstore_timer_kick();
 
-	/*
-	 * Update the module parameter backend, so it is visible
-	 * through /sys/module/pstore/parameters/backend
-	 */
-	backend = kstrdup(psi->name, GFP_KERNEL);
-
 	pr_info("Registered %s as persistent store backend\n", psi->name);
 
 	mutex_unlock(&psback_lock);
-- 
2.39.3