linux-kernel - Re: [PATCH v3 1/5] misc: fastrpc: Add fastrpc multimode invoke request support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023092840-rental-ascension-b062@gregkh>
Date:   Thu, 28 Sep 2023 15:07:11 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ekansh Gupta <quic_ekangupt@...cinc.com>
Cc:     srinivas.kandagatla@...aro.org, linux-arm-msm@...r.kernel.org,
        ekangupt@....qualcomm.com, linux-kernel@...r.kernel.org,
        fastrpc.upstream@....qualcomm.com
Subject: Re: [PATCH v3 1/5] misc: fastrpc: Add fastrpc multimode invoke
 request support

On Wed, Sep 20, 2023 at 04:17:03PM +0530, Ekansh Gupta wrote:
> Multimode invocation request is intended to support multiple
> different type of requests. This will include enhanced invoke
> request to support CRC check and performance counter enablement.
> This will also support few driver level user controllable
> mechanisms like usage of shared context banks, wakelock support,
> etc. This IOCTL is also added with the aim to support few
> new fastrpc features like DSP PD notification framework,
> DSP Signalling mechanism etc.

I can't see where you are properly checking the reserved fields in your
new ioctl structures, am I just missing that logic somewhere?

thanks,

greg k-h