[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230928132632.200263-1-fe@dev.tdt.de>
Date: Thu, 28 Sep 2023 15:26:28 +0200
From: Florian Eckert <fe@....tdt.de>
To: Eckert.Florian@...glemail.com, gregkh@...uxfoundation.org,
jirislaby@...nel.org, pavel@....cz, lee@...nel.org,
kabel@...nel.org, u.kleine-koenig@...gutronix.de
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
linux-leds@...r.kernel.org
Subject: [PATCH v2 0/4] ledtrig-tty: add new state evaluation
Changes in v2:
- rename new function from tty_get_mget() to tty_get_tiocm() as
requested by 'Jiri Slaby'.
- As suggested by 'Jiri Slaby', fixed tabs in function documentation
throughout the file '/drivers/tty/tty_io.c' in a separate commit.
- Move the variable definition to the top in function 'ledtrig_tty_work()'.
This was reported by the 'kernel test robot' after my change in v1.
- Also set the 'max_brightness' to 'blink_brightness' if no
'blink_brightness' was set. This fixes a problem at startup when the
brightness is still set to 0 and only 'line_*' is evaluated. I looked in
the netdev trigger and that's exactly how it's done there.
v1:
This is a follow-up patchset, based on the mailing list discussion from
March 2023 based on the old patchset v7 [1]. I have changed, the LED trigger
handling via the sysfs interfaces as suggested by Uwe Kleine-König.
[1]
https://lore.kernel.org/linux-leds/20230306093524.amm7o4ppa7gon4ew@pengutronix.de/
Florian Eckert (4):
tty: whitespaces in descriptions corrected by replacing tabs with
spaces.
tty: add new helper function tty_get_tiocm
trigger: ledtrig-tty: move variable definition to the top
trigger: ledtrig-tty: add new line mode to triggers
.../ABI/testing/sysfs-class-led-trigger-tty | 53 ++++
drivers/leds/trigger/ledtrig-tty.c | 280 +++++++++++++++++-
drivers/tty/tty_io.c | 130 ++++----
include/linux/tty.h | 1 +
4 files changed, 396 insertions(+), 68 deletions(-)
--
2.30.2
Powered by blists - more mailing lists