linux-kernel - Re: [PATCH V2] leds: sc27xx: Move mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230928133756.GI9999@google.com>
Date:   Thu, 28 Sep 2023 14:37:56 +0100
From:   Lee Jones <lee@...nel.org>
To:     Chunyan Zhang <chunyan.zhang@...soc.com>
Cc:     Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] leds: sc27xx: Move mutex_init() to the end of probe

On Mon, 25 Sep 2023, Chunyan Zhang wrote:

> Move the mutex_init() to avoid redundant mutex_destroy() calls after
> that for each time the probe fails.
> 
> Signed-off-by: Chunyan Zhang <chunyan.zhang@...soc.com>
> ---
> V2:
> - Move the mutex_init() to the end of .probe() instead of adding
> mutex_destroy() according to Lee's comments.
> ---
>  drivers/leds/leds-sc27xx-bltc.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)

Nice patch, but doesn't apply.

Please rebase (onto linux-next or for-leds-next) and resend.

-- 
Lee Jones [李琼斯]