linux-kernel - RE: [PATCH v2 1/2] leds: pca955x: Convert enum->pointer for data in the match tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OS0PR01MB5922F521B9FBBE7EA0D0646D86C1A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Date:   Thu, 28 Sep 2023 13:51:40 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     Lee Jones <lee@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     Pavel Machek <pavel@....cz>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Biju Das <biju.das.au@...il.com>
Subject: RE: [PATCH v2 1/2] leds: pca955x: Convert enum->pointer for data in
 the match tables

Hi Lee Jones,

> -----Original Message-----
> From: Lee Jones <lee@...nel.org>
> Sent: Thursday, September 28, 2023 2:44 PM
> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: Biju Das <biju.das.jz@...renesas.com>; Pavel Machek <pavel@....cz>;
> linux-leds@...r.kernel.org; linux-kernel@...r.kernel.org; Biju Das
> <biju.das.au@...il.com>
> Subject: Re: [PATCH v2 1/2] leds: pca955x: Convert enum->pointer for data
> in the match tables
> 
> On Mon, 25 Sep 2023, Andy Shevchenko wrote:
> 
> > On Sat, Sep 23, 2023 at 06:19:20PM +0100, Biju Das wrote:
> > > Convert enum->pointer for data in the match tables, so that
> > > device_get_match_data() can do match against OF/ACPI/I2C tables,
> > > once i2c bus type match support added to it.
> > >
> > > Replace enum->struct *pca955x_chipdefs for data in the match table.
> > > Simplify the probe() by replacing device_get_match_data() and ID
> > > lookup for retrieving data by i2c_get_match_data().
> > >
> > > While at it, add const definition to pca955x_chipdefs[].
> >
> > ...
> >
> > > -	struct pca955x_chipdef	*chipdef;
> > > +	const struct pca955x_chipdef	*chipdef;
> >
> > No need to preserve TAB(s) here.
> 
> Follow-up please.

Sure will send a follow-up patch to fix this tab issue as it is a separate change.

Cheers,
Biju