linux-kernel - Re: [PATCH v6 2/8] hugetlb: restructure pool allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230929205731.GA10357@monkey>
Date:   Fri, 29 Sep 2023 13:57:31 -0700
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Konrad Dybcio <konradybcio@...nel.org>
Cc:     Anshuman Khandual <anshuman.khandual@....com>,
        Xiongchun Duan <duanxiongchun@...edance.com>,
        Barry Song <21cnbao@...il.com>,
        David Rientjes <rientjes@...gle.com>,
        Miaohe Lin <linmiaohe@...wei.com>,
        Matthew Wilcox <willy@...radead.org>, linux-mm@...ck.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Naoya Horiguchi <naoya.horiguchi@...ux.dev>,
        Joao Martins <joao.m.martins@...cle.com>,
        David Hildenbrand <david@...hat.com>,
        Michal Hocko <mhocko@...e.com>,
        Oscar Salvador <osalvador@...e.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/8] hugetlb: restructure pool allocations

On 09/27/23 13:26, Konrad Dybcio wrote:
> 
> 
> On 26.09.2023 01:48, Mike Kravetz wrote:
> > Allocation of a hugetlb page for the hugetlb pool is done by the routine
> > alloc_pool_huge_page.  This routine will allocate contiguous pages from
> > a low level allocator, prep the pages for usage as a hugetlb page and
> > then add the resulting hugetlb page to the pool.
> > 
> > In the 'prep' stage, optional vmemmap optimization is done.  For
> > performance reasons we want to perform vmemmap optimization on multiple
> > hugetlb pages at once.  To do this, restructure the hugetlb pool
> > allocation code such that vmemmap optimization can be isolated and later
> > batched.
> > 
> > The code to allocate hugetlb pages from bootmem was also modified to
> > allow batching.
> > 
> > No functional changes, only code restructure.
> > 
> > Signed-off-by: Mike Kravetz <mike.kravetz@...cle.com>
> > Reviewed-by: Muchun Song <songmuchun@...edance.com>
> > ---
> Hi, looks like this patch prevents today's next from booting
> on at least one Qualcomm ARM64 platform. Reverting it makes
> the device boot again.

Can you share the config used and any other specific information such as
kernel command line.

I can not reproduce on the arm64 platforms I have.  Been trying various
config combinations without success.  Although, there are lots of
possibilities.  Also, taking a closer look at the changes.  So far,
nothing is obvious.
-- 
Mike Kravetz