linux-kernel - Re: [PATCH RESEND v5 7/8] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdb=8LU9Mkkn_VDcTGoH1pWn=hp9ZhN5dLm5pykif8cp-w@mail.gmail.com>
Date:   Sat, 30 Sep 2023 00:05:41 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Duje Mihanović <duje.mihanovic@...le.hr>
Cc:     Robert Jarzmik <robert.jarzmik@...e.fr>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Andy Shevchenko <andy@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Lubomir Rintel <lkundrak@...sk>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Tony Luck <tony.luck@...el.com>,
        "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-hardening@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        afaerber@...e.de, balejk@...fyz.cz
Subject: Re: [PATCH RESEND v5 7/8] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte

On Fri, Sep 29, 2023 at 5:42 PM Duje Mihanović <duje.mihanovic@...le.hr> wrote:

> Add DTS for Marvell PXA1908 SoC and Samsung Galaxy Core Prime Value
> Edition LTE, a smartphone based on said SoC.
>
> Signed-off-by: Duje Mihanović <duje.mihanovic@...le.hr>
(...)

> +&pmx {
> +       pinctrl-single,gpio-range = <&range 55 55 0>,
> +                                   <&range 110 32 0>,
> +                                   <&range 52 1 0>;
> +
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&board_pins_1 &board_pins_2 &board_pins_3>;
> +
> +       board_pins_1: pinmux-board-1 {
> +               pinctrl-single,pins = <
> +                       0x160 0
> +                       0x164 0
> +                       0x168 0
> +                       0x16c 0
> +               >;
> +               pinctrl-single,drive-strength = <0x1000 0x1800>;
> +               pinctrl-single,bias-pullup = <0x8000 0x8000 0 0xc000>;
> +               pinctrl-single,bias-pulldown = <0x8000 0x8000 0 0xa000>;
> +               pinctrl-single,input-schmitt = <0 0x30>;
> +               pinctrl-single,input-schmitt-enable = <0x40 0 0x40 0x40>;
> +               pinctrl-single,low-power-mode = <0x288 0x388>;
> +       };
(...)
> +                       pmx: pinmux@...00 {
> +                               compatible = "pinconf-single";

At least add a new binding for "marvell,pxa1908-padconf"
and use that like this:

compatible = "marvell,pxa1908-padconf", "pinconf-single";

When you use pinctrl-single you get the slightly opaque device
trees as seen above, so it's not something I'd recommend, I'd
rather write my own pin controller.

But it exists, so I can't say you can't use it. Not my choice.
I understand it is convenient.

It is possible to switch later, but only if you have a unique
pin controller compatible so please add that.

Yours,
Linus Walleij