linux-kernel - Re: [PATCH v1] misc: fastrpc: Reset metadata buffer to avoid incorrect free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e9200a1-cf3c-27ca-ceef-7d9b70297530@quicinc.com>
Date:   Fri, 29 Sep 2023 12:53:02 +0530
From:   Ekansh Gupta <quic_ekangupt@...cinc.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     <srinivas.kandagatla@...aro.org>, <linux-arm-msm@...r.kernel.org>,
        <ekangupt@....qualcomm.com>, <linux-kernel@...r.kernel.org>,
        <fastrpc.upstream@....qualcomm.com>
Subject: Re: [PATCH v1] misc: fastrpc: Reset metadata buffer to avoid
 incorrect free



On 9/28/2023 6:38 PM, Greg KH wrote:
> On Thu, Aug 31, 2023 at 12:05:23PM +0530, Ekansh Gupta wrote:
>> Metadata buffer is allocated during get_args for any remote call.
>> This buffer carries buffers, fdlists and other payload information
>> for the call. If the buffer is not reset, put_args might find some
>> garbage FDs in the fdlist which might have an existing mapping in
>> the list. This could result in improper freeing of FD map when DSP
>> might still be using the buffer. Added change to reset the metadata
>> buffer after allocation.
>>
>> Signed-off-by: Ekansh Gupta <quic_ekangupt@...cinc.com>
> 
> What commit id does this fix?
> 
> And you sent 3 patches, but not in a list, what order are they to be
> applied in?
> 
Thanks for reviewing the patches, Greg. I'll send the 3 patches as a 
patch series for better understanding.

-ekansh
> thanks,
> 
> greg k-h