linux-kernel - Re: [PATCH V12 2/3] dt-bindings: pwm: add IPQ6018 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4636a990-1044-1f67-dae5-8583f96021be@quicinc.com>
Date:   Fri, 29 Sep 2023 14:26:53 +0530
From:   Devi Priya <quic_devipriy@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <thierry.reding@...il.com>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <ndesaulniers@...gle.com>,
        <trix@...hat.com>, <baruch@...s.co.il>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <llvm@...ts.linux.dev>
CC:     <linux-pwm@...r.kernel.org>, <u.kleine-koenig@...gutronix.de>,
        <nathan@...nel.org>
Subject: Re: [PATCH V12 2/3] dt-bindings: pwm: add IPQ6018 binding



On 9/29/2023 1:25 PM, Devi Priya wrote:
> 
> 
> On 9/25/2023 12:41 PM, Krzysztof Kozlowski wrote:
>> On 25/09/2023 08:59, Devi Priya wrote:
>>> DT binding for the PWM block in Qualcomm IPQ6018 SoC.
>>>
>>> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
>>> Co-developed-by: Baruch Siach <baruch.siach@...lu.com>
>>> Signed-off-by: Baruch Siach <baruch.siach@...lu.com>
>>> Signed-off-by: Devi Priya <quic_devipriy@...cinc.com>
>>
>> ...
>>
>>> diff --git a/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml 
>>> b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml
>>> new file mode 100644
>>> index 000000000000..857086ad539e
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml
>>
>> Filename matching compatible, so qcom,ipq6018-pwm.yaml
> okay
We would have other ipq compatibles (ipq9574 & ipq5332) being added to
the binding in the upcoming series.
So, shall we rename the binding to qcom,ipq-pwm.yaml

Thanks,
Devi Priya
>>
>>> @@ -0,0 +1,53 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/pwm/ipq-pwm.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Qualcomm IPQ6018 PWM controller
>>> +
>>> +maintainers:
>>> +  - Baruch Siach <baruch@...s.co.il>
>>> +
>>> +properties:
>>> +  "#pwm-cells":
>>> +    const: 2
>>> +
>>> +  compatible:
>>> +    const: qcom,ipq6018-pwm
>>
>> compatible is always the first property.
> okay
>>
>>> +
>>> +  reg:
>>> +    description: Offset of PWM register in the TCSR block.
>>> +    maxItems: 1
>>> +
>>> +  clocks:
>>> +    maxItems: 1
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +  - clocks
>>> +  - "#pwm-cells"
>>
>> And this order must be the same as in properties.
> okay
>>
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> +  - |
>>> +    #include <dt-bindings/clock/qcom,gcc-ipq6018.h>
>>> +
>>> +    syscon@...7000 {
>>> +        compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd";
>>> +        reg = <0x01937000 0x21000>;
>>> +        #address-cells = <1>;
>>> +        #size-cells = <1>;
>>> +        ranges = <0 0x1937000 0x21000>;
>>
>> Drop this node, not related. The parent binding could have full example,
>> on the other hand. Additionally, I have doubts that you really tested
>> the parent binding.
> Sure, will drop the syscon node
> 
> Thanks,
> Devi Priya
>>
>>> +
>>> +        pwm: pwm@...0 {
>>> +            compatible = "qcom,ipq6018-pwm";
>>
>> Best regards,
>> Krzysztof
>>