linux-kernel - Re: [PATCH] m68k: defconfig: Update virt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd94cc5b-4918-0342-4781-69a031ab2d1f@vivier.eu>
Date:   Fri, 29 Sep 2023 11:44:47 +0200
From:   Laurent Vivier <laurent@...ier.eu>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k: defconfig: Update virt_defconfig for v6.6-rc3

Le 29/09/2023 à 11:01, Geert Uytterhoeven a écrit :
>    - Enable CONFIG_DRM_FBDEV_EMULATION and CONFIG_FB_DEVICE (no longer
>      auto-enabled since commit bb6c4507fe825f1b ("drm: fix up fbdev
>      Kconfig defaults")),
>    - Drop CONFIG_FRAMEBUFFER_CONSOLE=y (auto-enabled since commit
>      bb6c4507fe825f1b ("drm: fix up fbdev Kconfig defaults")).
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> Perhaps CONFIG_FB_DEVICE should not be enabled?

Why do you think it should not be enabled?

I think X was needing this to work on m68k.

Thanks,
Laurent

> 
> To be queued in the m68k for-v6.7 branch.
> ---
>   arch/m68k/configs/virt_defconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/m68k/configs/virt_defconfig b/arch/m68k/configs/virt_defconfig
> index 3afc6762b0946aa6..ec021a1d48ee7d86 100644
> --- a/arch/m68k/configs/virt_defconfig
> +++ b/arch/m68k/configs/virt_defconfig
> @@ -47,8 +47,9 @@ CONFIG_INPUT_EVDEV=y
>   CONFIG_VIRTIO_CONSOLE=y
>   CONFIG_HW_RANDOM_VIRTIO=y
>   CONFIG_DRM=y
> +CONFIG_DRM_FBDEV_EMULATION=y
>   CONFIG_DRM_VIRTIO_GPU=y
> -CONFIG_FRAMEBUFFER_CONSOLE=y
> +CONFIG_FB_DEVICE=y
>   CONFIG_SOUND=y
>   CONFIG_SND=y
>   CONFIG_SND_VIRTIO=y