[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d6e4fba3-ecaf-4cf3-8447-0f9a8f8bbaeb@amazon.com>
Date: Fri, 29 Sep 2023 12:45:37 +0200
From: Alexander Graf <graf@...zon.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
"Arnd Bergmann" <arnd@...db.de>,
Herbert Xu <herbert@...dor.apana.org.au>,
"Olivia Mackall" <olivia@...enic.com>,
Petre Eftime <petre.eftime@...il.com>,
"Erdem Meydanlli" <meydanli@...zon.nl>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
David Woodhouse <dwmw@...zon.co.uk>,
"Michael S . Tsirkin" <mst@...hat.com>,
Jason Wang <jasowang@...hat.com>,
Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Subject: Re: [PATCH 1/2] misc: Add Nitro Secure Module driver
On 29.09.23 07:45, Greg Kroah-Hartman wrote:
>
> On Thu, Sep 28, 2023 at 10:46:44PM +0000, Alexander Graf wrote:
>> +/* Register this as a misc driver */
>> +#define NSM_DEV_NAME "nsm"
>> +#define NSM_IOCTL_MAGIC 0x0A
>> +#define NSM_IO_REQUEST _IOWR(NSM_IOCTL_MAGIC, 0, struct nsm_message)
> You have an ioctl for this driver, yet no include/uapi/ file for it?
> How is userspace supposed to know about this and use it?
D'oh. Will fix :). Thanks!
Alex
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
Powered by blists - more mailing lists