linux-kernel - RE: [PATCH v8 0/5] Add Toshiba Visconti Video Input Interface driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYAPR01MB62012717ACB6D0C534DB559292C0A@TYAPR01MB6201.jpnprd01.prod.outlook.com>
Date:   Fri, 29 Sep 2023 01:49:39 +0000
From:   <yuji2.ishikawa@...hiba.co.jp>
To:     <hverkuil@...all.nl>, <laurent.pinchart@...asonboard.com>,
        <mchehab@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <nobuhiro1.iwamatsu@...hiba.co.jp>
CC:     <linux-media@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v8 0/5] Add Toshiba Visconti Video Input Interface driver

Hello Hans,

> -----Original Message-----
> From: Hans Verkuil <hverkuil@...all.nl>
> Sent: Wednesday, September 27, 2023 10:24 PM
> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> <yuji2.ishikawa@...hiba.co.jp>; Laurent Pinchart
> <laurent.pinchart@...asonboard.com>; Mauro Carvalho Chehab
> <mchehab@...nel.org>; Rob Herring <robh+dt@...nel.org>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@...aro.org>; Conor Dooley
> <conor+dt@...nel.org>; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○
> ＯＳＴ) <nobuhiro1.iwamatsu@...hiba.co.jp>
> Cc: linux-media@...r.kernel.org; devicetree@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v8 0/5] Add Toshiba Visconti Video Input Interface driver
> 
> Hi Yuji Ishikawa,
> 
> On 26/09/2023 01:28, Yuji Ishikawa wrote:
> > This series is the Video Input Interface driver for Toshiba's ARM SoC,
> > Visconti.
> > This provides DT binding documentation, device driver, documentation
> > and MAINTAINER files.
> >
> > A visconti VIIF driver instance exposes
> > 1 media control device file and 3 video device files for a VIIF
> > hardware.
> > Detailed HW/SW are described in documentation directory.
> > The VIIF hardware has CSI2 receiver,
> > image signal processor and DMAC inside.
> > The subdevice for image signal processor provides vendor specific V4L2
> > controls.
> >
> > The device driver depends on two other drivers under development;
> > clock framework driver and IOMMU driver.
> > Corresponding features will be added later.
> 
> Building this series results in a set of sparse warnings:

I set up the latest sparse tool and reproduced the warnings.

> drivers/media/platform/toshiba/visconti/viif_capture.c:235:29: warning: symbol
> 'out_format_spec' was not declared. Should it be static?

I'll set static qualifier.

> drivers/media/platform/toshiba/visconti/viif_capture.c:517:13: warning:
> context imbalance in 'viif_regbuf_access_start' - wrong count at exit
> drivers/media/platform/toshiba/visconti/viif_capture.c:523:13: warning:
> context imbalance in 'viif_regbuf_access_end' - unexpected unlock

I'll expand these inline functions.
The same sequences are already expanded in viif_controls.c

> drivers/media/platform/toshiba/visconti/viif_csi2rx.c:458:15: warning: Using
> plain integer as NULL pointer
> drivers/media/platform/toshiba/visconti/viif_csi2rx.c:458:15: warning: Using
> plain integer as NULL pointer

I'll fix them.

> And I also get a Documentation build warning:
> 
> Documentation/output/videodev2.h.rst:6: WARNING: undefined label:
> 'v4l2-ctrl-type-visconti-isp'

It seems the label is generated with a script (kerneldoc->ReST).
I also found that the other members of enum v4l2_ctrl_type have labels pointing at legal targets.
I'll try further to get a legal label.

> Also note that you need to rebase: the v4l2-controls.h header changed.

It seems that media-staging tree was updated after I fixed my patchset.
I should have re-check before submission.
I'll rebase to the latest HEAD and format v9 patch.

> Regards,
> 
> 	Hans
> 

Regards,
Yuji