linux-kernel - Re: [PATCH] tracing/eprobe: drop unneeded breaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2309291336260.3137@hadrien>
Date:   Fri, 29 Sep 2023 13:37:08 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Masami Hiramatsu <mhiramat@...nel.org>
cc:     Steven Rostedt <rostedt@...dmis.org>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing/eprobe: drop unneeded breaks



On Fri, 29 Sep 2023, Masami Hiramatsu  wrote:

> On Thu, 28 Sep 2023 12:43:34 +0200
> Julia Lawall <Julia.Lawall@...ia.fr> wrote:
>
> > Drop break after return.
> >
>
> Good catch! This looks good to me.
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
>
> And
>
> Fixes: 7491e2c44278 ("tracing: Add a probe that attaches to trace events")

Thanks.  I didn't include that because it's not a bug.  But it does break
Coccinelle, which is how I noticed it.

julia

>
> > Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>
> >
> > ---
> >  kernel/trace/trace_eprobe.c |    5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
> > index 72714cbf475c..03c851f57969 100644
> > --- a/kernel/trace/trace_eprobe.c
> > +++ b/kernel/trace/trace_eprobe.c
> > @@ -788,12 +788,9 @@ find_and_get_event(const char *system, const char *event_name)
> >  		name = trace_event_name(tp_event);
> >  		if (!name || strcmp(event_name, name))
> >  			continue;
> > -		if (!trace_event_try_get_ref(tp_event)) {
> > +		if (!trace_event_try_get_ref(tp_event))
> >  			return NULL;
> > -			break;
> > -		}
> >  		return tp_event;
> > -		break;
> >  	}
> >  	return NULL;
> >  }
> >
>
>
> --
> Masami Hiramatsu (Google) <mhiramat@...nel.org>
>