[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <169601032029.3005029.10504001720993389780.b4-ty@chromium.org>
Date: Fri, 29 Sep 2023 10:58:42 -0700
From: Kees Cook <keescook@...omium.org>
To: linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, Greg Ungerer <gerg@...nel.org>
Cc: Kees Cook <keescook@...omium.org>, palmer@...osinc.com,
ebiederm@...ssion.com, brauner@...nel.org, viro@...iv.linux.org.uk
Subject: Re: [PATCH] binfmt_elf_fdpic: clean up debug warnings
On Wed, 27 Sep 2023 23:29:33 +1000, Greg Ungerer wrote:
> The binfmt_elf_fdpic loader has some debug trace that can be enabled at
> build time. The recent 64-bit additions cause some warnings if that
> debug is enabled, such as:
>
> fs/binfmt_elf_fdpic.c: In function ‘elf_fdpic_map_file’:
> fs/binfmt_elf_fdpic.c:46:33: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘Elf64_Addr’ {aka ‘long long unsigned int’} [-Wformat=]
> 46 | #define kdebug(fmt, ...) printk("FDPIC "fmt"\n" ,##__VA_ARGS__ )
> | ^~~~~~~~
> ./include/linux/printk.h:427:25: note: in definition of macro ‘printk_index_wrap’
> 427 | _p_func(_fmt, ##__VA_ARGS__); \
> | ^~~~
>
> [...]
Applied to for-next/execve, thanks!
[1/1] binfmt_elf_fdpic: clean up debug warnings
https://git.kernel.org/kees/c/35bcdcf3d50c
Take care,
--
Kees Cook
Powered by blists - more mailing lists