linux-kernel - Re: [PATCH] fixed documentation warning about duplicate symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023093020-discern-dispersed-7dbe@gregkh>
Date:   Sat, 30 Sep 2023 15:31:42 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Abhinav <singhabhinav9051571833@...il.com>
Cc:     stern@...land.harvard.edu, benjamin.tissoires@...hat.com,
        mathias.nyman@...ux.intel.com, hdegoede@...hat.com,
        hadess@...ess.net, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, skhan@...uxfoundation.org
Subject: Re: [PATCH] fixed documentation warning about duplicate symbol

On Sat, Sep 30, 2023 at 06:04:49PM +0530, Abhinav wrote:
> Compiling the documentation in html gives a warning about duplicate symbol
> because same name is used for function usb_string(...) and 
> also for the struct usb_string.Also having a different name can
> be helpful while searching or debugging the code.
> 
> Renaming the function usb_string(...) to utf16le_to_utf8(...) fixes 
> this warning.Reason for choosing this name because 
> this is what the function description says it is doing.

Odd trailing spaces, why?

Anyway, sorry, but that's a horrible function name for a usb core
function, especially just for a documentation warning?  Surely the
documentation tools can determine the difference between a structure
name and a function name?  This can't be the only place this has ever
happened, right?

Try fixing the documentation tools instead?

thanks,

greg k-h