linux-kernel - Re: [PATCH] Fixed Kunit test warning message for 'fs' module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca559807-8456-4ff7-9edd-003480437a93@infradead.org>
Date:   Fri, 29 Sep 2023 19:45:37 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Abhinav <singhabhinav9051571833@...il.com>,
        akpm@...ux-foundation.org, david@...hat.com, rppt@...nel.org,
        hughd@...gle.com, Liam.Howlett@...cle.com, surenb@...gle.com,
        usama.anjum@...labora.com, wangkefeng.wang@...wei.com,
        ryan.roberts@....com, yuanchu@...gle.com
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        skhan@...uxfoundation.org
Subject: Re: [PATCH] Fixed Kunit test warning message for 'fs' module

Hi,

On 9/28/23 01:53, Abhinav wrote:
> fs/proc/task_mmu : fix warning
> 
> All the caller of the function pagemap_scan_backout_range(...) are inside
> ifdef preprocessor which is checking for the macro
> 'CONFIG_TRANSPARENT_HUGEPAGE' is set or not. When it is not set the
> function doesn't have a caller and it generates a warning unused
> function.
> 
> Putting the whole function inside the preprocessor fixes this warning.
> 
> Signed-off-by: Abhinav <singhabhinav9051571833@...il.com>

We have this patch:
  https://lore.kernel.org/all/20230927060257.2975412-1-arnd@kernel.org/

which is already merged.

Thanks.

> ---
>  fs/proc/task_mmu.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 27da6337d675..88b6b8847cf3 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -2019,6 +2019,7 @@ static bool pagemap_scan_push_range(unsigned long categories,
>  	return true;
>  }
>  
> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
>  static void pagemap_scan_backout_range(struct pagemap_scan_private *p,
>  				       unsigned long addr, unsigned long end)
>  {
> @@ -2031,6 +2032,7 @@ static void pagemap_scan_backout_range(struct pagemap_scan_private *p,
>  
>  	p->found_pages -= (end - addr) / PAGE_SIZE;
>  }
> +#endif
>  
>  static int pagemap_scan_output(unsigned long categories,
>  			       struct pagemap_scan_private *p,

-- 
~Randy