linux-kernel - Re: [PATCH v2] modpost: Don't let "driver"s reference .exit.*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATyRg6Hc-fnTETERj-tdMFGaBDt0Fyhy9+jKCzAvzQ6Pg@mail.gmail.com>
Date:   Sun, 1 Oct 2023 05:33:54 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Mathieu Poirier <mathieu.poirier@...aro.org>,
        Arnd Bergmann <arnd@...db.de>, linux-kbuild@...r.kernel.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        coresight@...ts.linaro.org,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-kernel@...r.kernel.org,
        Nathan Chancellor <nathan@...nel.org>,
        James Clark <james.clark@....com>, kernel@...gutronix.de,
        Leo Yan <leo.yan@...aro.org>,
        Nicolas Schier <nicolas@...sle.eu>,
        linux-arm-kernel@...ts.infradead.org,
        Mike Leach <mike.leach@...aro.org>
Subject: Re: [PATCH v2] modpost: Don't let "driver"s reference .exit.*

On Sun, Oct 1, 2023 at 1:52 AM Uwe Kleine-König
<u.kleine-koenig@...gutronix.de> wrote:
>
> Drivers must not reference functions marked with __exit as these likely
> are not available when the code is built-in.
>
> There are few creative offenders uncovered for example in ARCH=amd64
> allmodconfig builds. So only trigger the section mismatch warning for
> W=1 builds.
>
> The dual rule that drivers must not reference .init.* is implemented
> since commit 0db252452378 ("modpost: don't allow *driver to reference
> .init.*") which however missed that .exit.* should be handled in the
> same way.
>
> Thanks to Masahiro Yamada and Arnd Bergmann who gave valuable hints to
> find this improvement.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>


Thanks.

If there is no objection from anybody, I will apply this
to my fixes branch and send a pull request.


Then, I hope you (or somebody) will volunteer to fix broken drivers.





--
Best Regards
Masahiro Yamada