[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZRiQqLYpzJGbiqYX@hoboy.vegasvil.org>
Date: Sat, 30 Sep 2023 14:18:32 -0700
From: Richard Cochran <richardcochran@...il.com>
To: Mahesh Bandewar <maheshb@...gle.com>
Cc: Netdev <netdev@...r.kernel.org>,
Linux <linux-kernel@...r.kernel.org>,
David Miller <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>,
Jonathan Corbet <corbet@....net>,
Don Hatchett <hatch@...gle.com>,
Yuliang Li <yuliangli@...gle.com>,
Mahesh Bandewar <mahesh@...dewar.net>
Subject: Re: [PATCH 2/4] ptp: add ptp_gettimex64any() support
On Thu, Sep 28, 2023 at 07:37:40PM -0700, Mahesh Bandewar wrote:
> diff --git a/include/uapi/linux/ptp_clock.h b/include/uapi/linux/ptp_clock.h
> index 05cc35fc94ac..1f1e98966cff 100644
> --- a/include/uapi/linux/ptp_clock.h
> +++ b/include/uapi/linux/ptp_clock.h
> @@ -69,6 +69,14 @@
> */
> #define PTP_PEROUT_V1_VALID_FLAGS (0)
>
> +enum ptp_ts_types {
> + PTP_TS_CYCLES = 0,
> + PTP_TS_REAL,
> + PTP_TS_MONO,
> + PTP_TS_RAW,
> + PTP_TS_MAX,
> +};
There is no need for a new set of enumerated values. Why not use the
existing clockid_t ?
Thanks,
Richard
Powered by blists - more mailing lists