linux-kernel - Re: [PATCH] crypto: caam/qi2 - fix Chacha20 + Poly1305 self test failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZRku8WKoMiiUJdsX@gondor.apana.org.au>
Date:   Sun, 1 Oct 2023 16:33:53 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Gaurav Jain <gaurav.jain@....com>
Cc:     Horia Geanta <horia.geanta@....com>,
        Pankaj Gupta <pankaj.gupta@....com>,
        Varun Sethi <V.Sethi@....com>,
        Meenakshi Aggarwal <meenakshi.aggarwal@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Aisheng Dong <aisheng.dong@....com>,
        Silvano Di Ninno <silvano.dininno@....com>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-imx@....com
Subject: Re: [PATCH] crypto: caam/qi2 - fix Chacha20 + Poly1305 self test
 failure

On Thu, Sep 21, 2023 at 03:14:44PM +0530, Gaurav Jain wrote:
> key buffer is not copied in chachapoly_setkey function,
> results in wrong output for encryption/decryption operation.
> 
> fix this by memcpy the key in caam_ctx key arrary
> 
> Fixes: c10a53367901 ("crypto: caam/qi2 - add support for Chacha20 + Poly1305")
> Signed-off-by: Gaurav Jain <gaurav.jain@....com>
> ---
>  drivers/crypto/caam/caamalg_qi2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt