linux-kernel - Re: [PATCH] media: ipu-bridge: Add missing acpi_dev_put() in ipu_bridge_get_ivsc_acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZRk7JrCxUhgJ/zhf@smile.fi.intel.com>
Date:   Sun, 1 Oct 2023 12:25:58 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Wentong Wu <wentong.wu@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: ipu-bridge: Add missing acpi_dev_put() in
 ipu_bridge_get_ivsc_acpi_dev()

On Fri, Sep 29, 2023 at 11:31:33AM +0200, Geert Uytterhoeven wrote:
> In ipu_bridge_get_ivsc_acpi_dev(), the "ivsc_adev" acpi_device pointer
> from the outer loop is handed over to the caller, which takes proper
> care of its reference count.
> However, the "consumer" acpi_device pointer from the inner loop is lost,
> without decrementing its reference count.
> 
> Fix this by adding the missing call to acpi_dev_put().

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko