linux-kernel - Re: [PATCH 1/9] accel/habanalabs: minor cosmetics update to cpucp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1723bb09-0637-161a-63b9-e63345c5c261@habana.ai>
Date:   Sun, 1 Oct 2023 09:13:18 +0000
From:   Ofir Bitton <obitton@...ana.ai>
To:     Oded Gabbay <ogabbay@...nel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/9] accel/habanalabs: minor cosmetics update to
 cpucp_if.h

On 26/09/2023 11:13, Oded Gabbay wrote:
> - Update copyright years
> - Align comments
> 
> Signed-off-by: Oded Gabbay <ogabbay@...nel.org>
> ---
>   include/linux/habanalabs/cpucp_if.h | 17 +++++++----------
>   1 file changed, 7 insertions(+), 10 deletions(-)
> 
> diff --git a/include/linux/habanalabs/cpucp_if.h b/include/linux/habanalabs/cpucp_if.h
> index 84d74c4ee4d3..86ea7c63a0d2 100644
> --- a/include/linux/habanalabs/cpucp_if.h
> +++ b/include/linux/habanalabs/cpucp_if.h
> @@ -1,6 +1,6 @@
>   /* SPDX-License-Identifier: GPL-2.0
>    *
> - * Copyright 2020-2022 HabanaLabs, Ltd.
> + * Copyright 2020-2023 HabanaLabs, Ltd.
>    * All Rights Reserved.
>    *
>    */
> @@ -668,18 +668,15 @@ enum pq_init_status {
>    *       Obsolete.
>    *
>    * CPUCP_PACKET_GENERIC_PASSTHROUGH -
> - *      Generic opcode for all firmware info that is only passed to host
> - *      through the LKD, without getting parsed there.
> + *       Generic opcode for all firmware info that is only passed to host
> + *       through the LKD, without getting parsed there.
>    *
>    * CPUCP_PACKET_ACTIVE_STATUS_SET -
>    *       LKD sends FW indication whether device is free or in use, this indication is reported
>    *       also to the BMC.
>    *
> - * CPUCP_PACKET_REGISTER_INTERRUPTS -
> - *       Packet to register interrupts indicating LKD is ready to receive events from FW.
> - *
>    * CPUCP_PACKET_SOFT_RESET -
> - *      Packet to perform soft-reset.
> + *       Packet to perform soft-reset.
>    *
>    * CPUCP_PACKET_INTS_REGISTER -
>    *       Packet to inform FW that queues have been established and LKD is ready to receive
> @@ -750,9 +747,9 @@ enum cpucp_packet_id {
>   	CPUCP_PACKET_RESERVED11,		/* not used */
>   	CPUCP_PACKET_RESERVED12,		/* internal */
>   	CPUCP_PACKET_RESERVED13,                /* internal */
> -	CPUCP_PACKET_SOFT_RESET,                /* internal */
> -	CPUCP_PACKET_INTS_REGISTER,             /* internal */
> -	CPUCP_PACKET_ID_MAX                     /* must be last */
> +	CPUCP_PACKET_SOFT_RESET,		/* internal */
> +	CPUCP_PACKET_INTS_REGISTER,		/* internal */
> +	CPUCP_PACKET_ID_MAX			/* must be last */
>   };
>   
>   #define CPUCP_PACKET_FENCE_VAL	0xFE8CE7A5

Ack for the whole series.

Reviewed-by: Ofir Bitton <obitton@...ana.ai>