linux-kernel - Re: [PATCH v1 0/3] Add fixes for FastRPC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <230ca044-99c7-45df-9947-4605b8c0d295@linaro.org>
Date:   Sun, 1 Oct 2023 15:40:30 +0100
From:   Caleb Connolly <caleb.connolly@...aro.org>
To:     Ekansh Gupta <quic_ekangupt@...cinc.com>,
        srinivas.kandagatla@...aro.org, linux-arm-msm@...r.kernel.org
Cc:     ekangupt@....qualcomm.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, fastrpc.upstream@....qualcomm.com
Subject: Re: [PATCH v1 0/3] Add fixes for FastRPC driver

On 29/09/2023 08:42, Ekansh Gupta wrote:
> This patchset carries the following fixes.
> - Reset metadata buffer to avoid incorrect fd getting freed
> - Free DMA handles for remote calls with no arguments
> - Clean buffers on remote call failures

Bit of a nit pick here, but you should try and use the cover letter to 
explain the necessary context and justification for your series. An 
overview of the commits is already included below by b4 or git-send-email.

It would be good to establish if these fixes are all related in some way 
(ie to enable a specific usecase), or if it's just a few random things 
that folks have discovered. Although it's almost always useful for 
maintainers to know how these issues where discovered as it could expose 
a gap in testing.

Regards,

> 
> Ekansh Gupta (3):
>    misc: fastrpc: Reset metadata buffer to avoid incorrect free
>    misc: fastrpc: Free DMA handles for RPC calls with no arguments
>    misc: fastrpc: Clean buffers on remote invocation failures
> 
>   drivers/misc/fastrpc.c | 26 ++++++++++++--------------
>   1 file changed, 12 insertions(+), 14 deletions(-)
> 

-- 
// Caleb (they/them)