linux-kernel - Re: [PATCH v6 09/11] firmware: imx: enable trng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202310011350.nKG627KP-lkp@intel.com>
Date:   Sun, 1 Oct 2023 13:25:08 +0800
From:   kernel test robot <lkp@...el.com>
To:     Pankaj Gupta <pankaj.gupta@....com>, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, clin@...e.com,
        conor+dt@...nel.org, pierre.gondois@....com, festevam@...il.com,
        linux-imx@....com, davem@...emloft.net, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, gaurav.jain@....com,
        alexander.stein@...tq-group.com, V.Sethi@....com
Cc:     oe-kbuild-all@...ts.linux.dev, Pankaj Gupta <pankaj.gupta@....com>
Subject: Re: [PATCH v6 09/11] firmware: imx: enable trng

Hi Pankaj,

kernel test robot noticed the following build errors:

[auto build test ERROR on shawnguo/for-next]
[also build test ERROR on robh/for-next linus/master v6.6-rc3]
[cannot apply to next-20230929]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Pankaj-Gupta/Documentation-firmware-added-imx-se-fw-to-other_interfaces/20230927-202918
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
patch link:    https://lore.kernel.org/r/20230927175401.1962733-10-pankaj.gupta%40nxp.com
patch subject: [PATCH v6 09/11] firmware: imx: enable trng
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20231001/202310011350.nKG627KP-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231001/202310011350.nKG627KP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310011350.nKG627KP-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/firmware/imx/ele_trng.c:16:5: error: redefinition of 'ele_trng_init'
      16 | int ele_trng_init(struct device *dev)
         |     ^~~~~~~~~~~~~
   In file included from drivers/firmware/imx/ele_trng.c:8:
   drivers/firmware/imx/ele_common.h:25:19: note: previous definition of 'ele_trng_init' with type 'int(struct device *)'
      25 | static inline int ele_trng_init(struct device *dev)
         |                   ^~~~~~~~~~~~~


vim +/ele_trng_init +16 drivers/firmware/imx/ele_trng.c

    15	
  > 16	int ele_trng_init(struct device *dev)
    17	{
    18		struct ele_trng *trng;
    19		int ret;
    20	
    21		trng = devm_kzalloc(dev, sizeof(*trng), GFP_KERNEL);
    22		if (!trng)
    23			return -ENOMEM;
    24	
    25		trng->dev         = dev;
    26		trng->rng.name    = "ele-trng";
    27		trng->rng.read    = ele_get_hwrng;
    28		trng->rng.priv    = (unsigned long)trng;
    29		trng->rng.quality = 1024;
    30	
    31		dev_dbg(dev, "registering ele-trng\n");
    32	
    33		ret = devm_hwrng_register(dev, &trng->rng);
    34		if (ret)
    35			return ret;
    36	
    37		dev_info(dev, "Successfully registered ele-trng\n");
    38		return 0;
    39	}
    40	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki