linux-kernel - Re: [PATCH] selftests:proc add missing field KSM in smaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 1 Oct 2023 12:52:49 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Swarup Laxman Kotiaklapudi <swarupkotikalapudi@...il.com>
Cc:     shuah@...nel.org, hughd@...gle.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] selftests:proc add missing field KSM in smaps_rollup[]
 array

On Sat, 30 Sep 2023 17:55:23 +0530 Swarup Laxman Kotiaklapudi <swarupkotikalapudi@...il.com> wrote:

> Missing field KSM is added in g_smaps_rollup[] array as it
> fixes assert in function test_proc_pid_smaps_rollup()
> 
> Without this patchset test fails for "proc-empty-vm" as can be seen below:
> $make TARGETS="proc" kselftest
> ...
>   selftests: proc: proc-empty-vm
>   proc-empty-vm: proc-empty-vm.c:299: test_proc_pid_smaps_rollup:
>    Assertion `rv == sizeof(g_smaps_rollup) - 1' failed.
>   /usr/bin/timeout: the monitored command dumped core
>   Aborted
>   not ok 5 selftests: proc: proc-empty-vm # exit=134
> ...
> 
> With this patchset test passes for "proc-empty-vm" as can be seen below:
> $make TARGETS="proc" kselftest
> ....
> timeout set to 45
> selftests: proc: proc-empty-vm
> ok 5 selftests: proc: proc-empty-vm
> ....
> 

Thanks.  We fixed this in

commit 9d1be94df5acd486b157e85ffa53d344e5b17e22
Author: Alexey Dobriyan <adobriyan@...il.com>
Date:   Thu Sep 7 14:10:12 2023 +0300

    selftests/proc: fixup proc-empty-vm test after KSM changes