linux-kernel - Re: [PATCH] drivers: usb: Remove unnecessary whitespace in function pointer declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 1 Oct 2023 08:12:34 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jonathan Bergh <bergh.jonathan@...il.com>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: usb: Remove unnecessary whitespace in function
 pointer declaration

On Sat, Sep 30, 2023 at 10:41:36PM +0200, Jonathan Bergh wrote:
> Fixed a formatting issue flagged by checkpatch where unnecessary
> whitespace was included before the parameter list in the function
> pointer declaration.
> 
> Signed-off-by: Jonathan Bergh <bergh.jonathan@...il.com>
> ---
>  drivers/usb/c67x00/c67x00.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/c67x00/c67x00.h b/drivers/usb/c67x00/c67x00.h
> index a4456d0fffa9..3673357818b4 100644
> --- a/drivers/usb/c67x00/c67x00.h
> +++ b/drivers/usb/c67x00/c67x00.h
> @@ -193,7 +193,7 @@ struct c67x00_sie {
>  	/* Entries to be used by the subdrivers */
>  	spinlock_t lock;	/* protect this structure */
>  	void *private_data;
> -	void (*irq) (struct c67x00_sie *sie, u16 int_status, u16 msg);
> +	void (*irq)(struct c67x00_sie *sie, u16 int_status, u16 msg);

Same comment as on the other patches, subject line is incorrect, and why
do this?

thanks,

greg k-h