[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <8bd0a7944f0f4f1342333eaf8d92d8e9d5623110.1696141233.git.christophe.jaillet@wanadoo.fr>
Date: Sun, 1 Oct 2023 08:20:51 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Vadim Pasternak <vadimp@...dia.com>,
Hans de Goede <hdegoede@...hat.com>,
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
Mark Gross <markgross@...nel.org>,
Michael Shych <michaelsh@...dia.com>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
Christophe JAILLET <christophe.jaillet@...adoo.fr>,
platform-driver-x86@...r.kernel.org
Subject: [PATCH] platform: mellanox: Fix a resource leak in an error handling path in mlxplat_probe()
If an error occurs after a successful mlxplat_i2c_main_init(),
mlxplat_i2c_main_exit() should be called to free some resources.
Add the missing call, as already done in the remove function.
Fixes: 158cd8320776 ("platform: mellanox: Split logic in init and exit flow")
Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
---
This patch is based on comparison between functions called in the remove
function and the error handling path of the probe.
For some reason, the way the code is written and function names are
puzzling to me. So Review with care!
---
drivers/platform/x86/mlx-platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index 3d96dbf79a72..64701b63336e 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -6598,6 +6598,7 @@ static int mlxplat_probe(struct platform_device *pdev)
fail_register_reboot_notifier:
fail_regcache_sync:
mlxplat_pre_exit(priv);
+ mlxplat_i2c_main_exit(priv);
fail_mlxplat_i2c_main_init:
fail_regmap_write:
fail_alloc:
--
2.34.1
Powered by blists - more mailing lists