linux-kernel - Re: [PATCH] drm/bridge: tc358767: Convert to use maple tree register cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0431777c-a0bc-4d50-9657-ae4e9e4aec18@linaro.org>
Date:   Mon, 2 Oct 2023 09:02:16 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Mark Brown <broonie@...nel.org>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Robert Foss <rfoss@...nel.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: tc358767: Convert to use maple tree register
 cache

On 01/10/2023 01:43, Mark Brown wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>   drivers/gpu/drm/bridge/tc358767.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index b45bffab7c81..ef2e373606ba 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -2005,7 +2005,7 @@ static const struct regmap_config tc_regmap_config = {
>   	.val_bits = 32,
>   	.reg_stride = 4,
>   	.max_register = PLL_DBG,
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>   	.readable_reg = tc_readable_reg,
>   	.volatile_table = &tc_volatile_table,
>   	.writeable_reg = tc_writeable_reg,
> 
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
> change-id: 20230929-drm-tc358767-maple-db143f667958
> 
> Best regards,

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>