[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAP6Zq1jM3=D5PBp1z7=K6LRNJaZe3rEPutXm_xxo7p2Z60sWmQ@mail.gmail.com>
Date: Mon, 2 Oct 2023 21:29:40 +0300
From: Tomer Maimon <tmaimon77@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: ulf.hansson@...aro.org, avifishman70@...il.com,
tali.perry1@...il.com, joel@....id.au, venture@...gle.com,
yuenn@...gle.com, benjaminfair@...gle.com, adrian.hunter@...el.com,
skhan@...uxfoundation.org, davidgow@...gle.com,
pbrobinson@...il.com, gsomlo@...il.com, briannorris@...omium.org,
arnd@...db.de, krakoczy@...micro.com, openbmc@...ts.ozlabs.org,
linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver
Hi Andy,
Thanks for your comments.
On Mon, 2 Oct 2023 at 21:22, Andy Shevchenko <andy.shevchenko@...il.com> wrote:
>
> On Mon, Oct 2, 2023 at 8:51 PM Tomer Maimon <tmaimon77@...il.com> wrote:
> >
> > Add Nuvoton NPCM BMC sdhci-pltfm controller driver.
>
> ...
>
> > +/*
> > + * NPCM SDHC MMC host controller driver.
> > + *
> > + * Copyright (c) 2020 Nuvoton Technology corporation.
>
> Shouldn't it be at least 2020,2023 ?
will change to 2023
>
> > + */
>
> ...
>
> > +#include <linux/clk.h>
> > +#include <linux/err.h>
> > +#include <linux/io.h>
> > +#include <linux/mmc/host.h>
> > +#include <linux/mmc/mmc.h>
>
> + mod_devicetable.h
why?
> > +#include <linux/module.h>
> > +#include <linux/of.h>
>
> ...
>
> > + pltfm_host->clk = devm_clk_get_optional(&pdev->dev, NULL);
> > + if (IS_ERR(pltfm_host->clk)) {
> > + ret = PTR_ERR(pltfm_host->clk);
> > + goto err_sdhci;
> > + }
> > +
> > + ret = clk_prepare_enable(pltfm_host->clk);
> > + if (ret)
> > + goto err_sdhci;
>
> Why not use devm_clk_get_optional_enabled()?
Will do
>
> --
> With Best Regards,
> Andy Shevchenko
Best regards,
Tomer
Powered by blists - more mailing lists