linux-kernel - Re: [PATCH v5 1/3] debugfs_create_regset32() support 8/16 bit width registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <77c827ac-06a3-44fc-97ff-45db82ac0206@app.fastmail.com>
Date:   Mon, 02 Oct 2023 21:39:37 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Frank Li" <Frank.li@....com>
Cc:     "Vinod Koul" <vkoul@...nel.org>, "Baoquan He" <bhe@...hat.com>,
        dmaengine@...r.kernel.org,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        imx@...ts.linux.dev, linux-kernel@...r.kernel.org,
        "kernel test robot" <lkp@...el.com>, oe-kbuild-all@...ts.linux.dev,
        "Rafael J . Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v5 1/3] debugfs_create_regset32() support 8/16 bit width registers

On Mon, Oct 2, 2023, at 21:07, Frank Li wrote:
> On Mon, Oct 02, 2023 at 08:55:23PM +0200, Arnd Bergmann wrote:
>
>> A few other thoughts from my side, all of which could be ignored:
>> 
>> - if the ioport access is not an important feature, we can instead
>>   support 64-bit readl() as I commented in a previous email. We just
>>   can't easily have both.
>
> We will get 64bit dma edma soon. So I can test and upstream it when I get
> it.

Ok, so if we already know this is going to be needed, then I would skip
the PIO support and just use read{bwlq}() with the optional swab() instead
of the ioread variants. Otherwise there is a risk that someone starts
relying on the port I/O feature and make it harder to remove.

     Arnd