[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAP6Zq1gnjDUSWqe2aNMfMx-Ksdx_Mw6skCu4ecRC4na2A-UNkg@mail.gmail.com>
Date: Mon, 2 Oct 2023 23:07:39 +0300
From: Tomer Maimon <tmaimon77@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: ulf.hansson@...aro.org, avifishman70@...il.com,
tali.perry1@...il.com, joel@....id.au, venture@...gle.com,
yuenn@...gle.com, benjaminfair@...gle.com, adrian.hunter@...el.com,
skhan@...uxfoundation.org, davidgow@...gle.com,
pbrobinson@...il.com, gsomlo@...il.com, briannorris@...omium.org,
arnd@...db.de, krakoczy@...micro.com, openbmc@...ts.ozlabs.org,
linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver
Hi Andy
Thank a lot Address in V5
On Mon, 2 Oct 2023 at 22:46, Andy Shevchenko <andy.shevchenko@...il.com> wrote:
>
> On Mon, Oct 2, 2023 at 10:41 PM Tomer Maimon <tmaimon77@...il.com> wrote:
> >
> > Add Nuvoton NPCM BMC sdhci-pltfm controller driver.
>
> ...
>
> > + pltfm_host->clk = devm_clk_get_optional_enabled(dev, NULL);
> > + if (IS_ERR(pltfm_host->clk)) {
> > + ret = PTR_ERR(pltfm_host->clk);
> > + goto err_sdhci;
> > + }
>
> ...
>
> > +err_sdhci_clk:
> > + clk_disable_unprepare(pltfm_host->clk);
>
> Now this is leftover that leads to unbalanced reference counting.
>
> --
> With Best Regards,
> Andy Shevchenko
Powered by blists - more mailing lists