[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231002214528.15529-1-phil@philpotter.co.uk>
Date: Mon, 2 Oct 2023 22:45:28 +0100
From: Phillip Potter <phil@...lpotter.co.uk>
To: devnull+j.granados.samsung.com@...nel.org
Cc: Jason@...c4.com, airlied@...il.com, arnd@...db.de,
clemens@...isch.de, daniel@...ll.ch, davem@...emloft.net,
decui@...rosoft.com, dgilbert@...erlog.com,
dri-devel@...ts.freedesktop.org, dsahern@...nel.org,
edumazet@...gle.com, gregkh@...uxfoundation.org,
haiyangz@...rosoft.com, intel-gfx@...ts.freedesktop.org,
j.granados@...sung.com, jani.nikula@...ux.intel.com,
jejb@...ux.ibm.com, jgg@...pe.ca, jgross@...e.com,
jirislaby@...nel.org, joonas.lahtinen@...ux.intel.com,
josh@...htriplett.org, keescook@...omium.org, kuba@...nel.org,
kys@...rosoft.com, leon@...nel.org, linux-hyperv@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
linux-rdma@...r.kernel.org, linux-scsi@...r.kernel.org,
linux-serial@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
martin.petersen@...cle.com, mcgrof@...nel.org, minyard@....org,
netdev@...r.kernel.org, oleksandr_tyshchenko@...m.com,
openipmi-developer@...ts.sourceforge.net, pabeni@...hat.com,
phil@...lpotter.co.uk, rafael@...nel.org, robinmholt@...il.com,
rodrigo.vivi@...el.com, russell.h.weight@...el.com,
song@...nel.org, sstabellini@...nel.org, steve.wahl@....com,
sudipm.mukherjee@...il.com, tvrtko.ursulin@...ux.intel.com,
tytso@....edu, wei.liu@...nel.org, willy@...radead.org,
xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v2 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array
> From: Joel Granados <j.granados@...sung.com>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
>
> Remove sentinel element from cdrom_table
>
> Signed-off-by: Joel Granados <j.granados@...sung.com>
> ---
> drivers/cdrom/cdrom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index cc2839805983..a5e07270e0d4 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -3655,7 +3655,6 @@ static struct ctl_table cdrom_table[] = {
> .mode = 0644,
> .proc_handler = cdrom_sysctl_handler
> },
> - { }
> };
> static struct ctl_table_header *cdrom_sysctl_header;
>
>
> --
> 2.30.2
Hi Joel,
Looks good to me, many thanks. I'll send on for inclusion.
Reviewed-by: Phillip Potter <phil@...lpotter.co.uk>
Regards,
Phil
Powered by blists - more mailing lists