[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5e354fef-555f-f461-c847-3ee694152d06@intel.com>
Date: Mon, 2 Oct 2023 16:01:06 -0700
From: "Joseph, Jithu" <jithu.joseph@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC: Hans de Goede <hdegoede@...hat.com>, <markgross@...nel.org>,
<tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>,
<dave.hansen@...ux.intel.com>, <x86@...nel.org>, <hpa@...or.com>,
<rostedt@...dmis.org>, <ashok.raj@...el.com>,
<tony.luck@...el.com>, LKML <linux-kernel@...r.kernel.org>,
<platform-driver-x86@...r.kernel.org>, <patches@...ts.linux.dev>,
<ravi.v.shankar@...el.com>, <pengfei.xu@...el.com>
Subject: Re: [PATCH v3 9/9] platform/x86/intel/ifs: ARRAY BIST for Sierra
Forest
On 10/2/2023 4:59 AM, Ilpo Järvinen wrote:
>
> Just a suggestion that would IMO make these easier to understand, you
> could name these array generations with defines so that one does not need
> to look what's defined in X86_MATCH() to understand the purpose of the
> second parameter. But it's up to you.
>
I can make this change ... Thanks for the review
Jithu
Powered by blists - more mailing lists