linux-kernel - Re: [PATCH v5 01/11] dt-bindings: document generic access controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <f3dbcd84-1320-9efb-f715-71b6bb4c7bdb@foss.st.com>
Date:   Mon, 2 Oct 2023 11:10:05 +0200
From:   Gatien CHEVALLIER <gatien.chevallier@...s.st.com>
To:     Rob Herring <robh@...nel.org>
CC:     <arnd@...nel.org>, <linux-phy@...ts.infradead.org>,
        <linux-mmc@...r.kernel.org>, <dmaengine@...r.kernel.org>,
        <robh+dt@...nel.org>, <jic23@...nel.org>, <davem@...emloft.net>,
        <kuba@...nel.org>, <pabeni@...hat.com>,
        <linux-spi@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
        <olivier.moysan@...s.st.com>, <linux-media@...r.kernel.org>,
        <krzysztof.kozlowski+dt@...aro.org>,
        Oleksii Moisieiev <oleksii_moisieiev@...m.com>,
        <edumazet@...gle.com>, <linux-stm32@...md-mailman.stormreply.com>,
        <ulf.hansson@...aro.org>, <richardcochran@...il.com>,
        <will@...nel.org>, <linux-crypto@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <arnaud.pouliquen@...s.st.com>, <linux-serial@...r.kernel.org>,
        <alexandre.torgue@...s.st.com>,
        Frank Rowand <frowand.list@...il.com>, <andi.shyti@...nel.org>,
        <linux-usb@...r.kernel.org>, <peng.fan@....nxp.com>,
        <lee@...nel.org>, <fabrice.gasnier@...s.st.com>,
        <conor+dt@...nel.org>, <herbert@...dor.apana.org.au>,
        <linux-arm-kernel@...ts.infradead.org>, <catalin.marinas@....com>,
        <al.sa-devel@...a-project.org>, <hugues.fruchet@...s.st.com>,
        <devicetree@...r.kernel.org>, <linux-iio@...r.kernel.org>,
        <mchehab@...nel.org>, <vkoul@...nel.org>,
        <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v5 01/11] dt-bindings: document generic access controller



On 9/29/23 17:35, Rob Herring wrote:
> 
> On Fri, 29 Sep 2023 16:28:42 +0200, Gatien Chevallier wrote:
>> From: Oleksii Moisieiev <Oleksii_Moisieiev@...m.com>
>>
>> Introducing of the generic access controller bindings for the
>> access controller provider and consumer devices. Those bindings are
>> intended to allow a better handling of accesses to resources in a
>> hardware architecture supporting several compartments.
>>
>> This patch is based on [1]. It is integrated in this patchset as it
>> provides a use-case for it.
>>
>> Diffs with [1]:
>> 	- Rename feature-domain* properties to access-control* to narrow
>> 	  down the scope of the binding
>> 	- YAML errors and typos corrected.
>> 	- Example updated
>> 	- Some rephrasing in the binding description
>>
>> [1]: https://lore.kernel.org/lkml/0c0a82bb-18ae-d057-562b
>>
>> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@...m.com>
>> Signed-off-by: Gatien Chevallier <gatien.chevallier@...s.st.com>
>>
>> ---
>> Changes in V5:
>> 	- Diffs with [1]
>> 	- Discarded the [IGNORE] tag as the patch is now part of the
>> 	  patchset
>>
>>   .../access-controllers/access-controller.yaml | 90 +++++++++++++++++++
>>   1 file changed, 90 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/access-controllers/access-controller.yaml
>>
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/access-controllers/access-controller.yaml: access-control-provider: missing type definition
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230929142852.578394-2-gatien.chevallier@foss.st.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
> 

Hi Rob,

Running:
1- make dt_binding_check | grep access-control
2- make dt_binding_check 
DT_SCHEMA_FILES=Documentation/devicetree/bindings/access-controllers/access-controller.yaml
from Krzysztof's slideset

with

pip3 show dtschema
Name: dtschema
Version: 2023.9

and

pip3 show yamllint
Name: yamllint
Version: 1.32.0

I don't see any of the errors reported by the robot. I have to clone
your repository to reproduce it.

Should I resubmit with a clean dt-check using the latest dtschema?

***********
However, I get:
warning: ignoring duplicate '$id' value 
'http://devicetree.org/schemas/reserved-memory/framebuffer.yaml#
warning: ignoring duplicate '$id' value 
'http://devicetree.org/schemas/reserved-memory/memory-region.yaml#
warning: ignoring duplicate '$id' value 
'http://devicetree.org/schemas/reserved-memory/shared-dma-pool.yaml#
warning: ignoring duplicate '$id' value 
'http://devicetree.org/schemas/reserved-memory/reserved-memory.yaml

Above warnings disappears when switching to:
pip3 show dtschema
Name: dtschema
Version: 2023.7

The above YAMLs seem to be duplicated in dtschema's latest version.
I guess it's a synchro that needs to be done since:
https://lore.kernel.org/all/20230830231758.2561402-2-sjg@chromium.org/
***********

Best regards,
Gatien