linux-kernel - Re: [PATCH] mm/filemap: clarify filemap_fault() comments for not uptodate case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6fb3fa0fe3e53d6e31c8ab6f96a9549da1d659f0.camel@perches.com>
Date:   Mon, 02 Oct 2023 02:43:41 -0700
From:   Joe Perches <joe@...ches.com>
To:     Vlastimil Babka <vbabka@...e.cz>,
        Christoph Hellwig <hch@...radead.org>,
        Lorenzo Stoakes <lstoakes@...il.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Matthew Wilcox <willy@...radead.org>, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] mm/filemap: clarify filemap_fault() comments for not
 uptodate case

On Mon, 2023-10-02 at 08:39 +0200, Vlastimil Babka wrote:
> On 10/2/23 08:26, Christoph Hellwig wrote:
> > > +		 * If the invalidate lock is not held, the folio was in cache and
> > > +		 * uptodate and now it is not. Strange but possible since we
> > 
> > Please don't spill block comments ôver the 80 charater limit, that makes
> > them impossible to read nicely.
> 
> Joe, can we revert the default to 80 to avoid everyone having to alias
> --max-line-length=80 locally?

Given the current --max-line-length default is 100,
and that was Linus' preference, I think not.

https://lore.kernel.org/lkml/CAHk-=wj3iGQqjpvc+gf6+C29Jo4COj6OQQFzdY0h5qvYKTdCow@mail.gmail.com/

and

https://lore.kernel.org/lkml/CAHk-=wjR0H3+2ba0UUWwoYzYBH0GX9yTf5dj2MZyo0xvyzvJnA@mail.gmail.com/