linux-kernel - Re: [PATCH] Revert "drm/amd/display: Check all enabled planes in dm_check_crtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39342931-1716-bf53-62d7-613b1191f60a@mailbox.org>
Date:   Mon, 2 Oct 2023 12:48:44 +0200
From:   Michel Dänzer <michel.daenzer@...lbox.org>
To:     Hamza Mahfooz <hamza.mahfooz@....com>
Cc:     Stylon Wang <stylon.wang@....com>, Ivan Lipski <ivlipski@....com>,
        Leo Li <sunpeng.li@....com>,
        Harry Wentland <harry.wentland@....com>,
        Qingqing Zhuo <Qingqing.Zhuo@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Alex Hung <alex.hung@....com>,
        Michel Dänzer <mdaenzer@...hat.com>,
        Aurabindo Pillai <aurabindo.pillai@....com>,
        Hersen Wu <hersenxs.wu@....com>, amd-gfx@...ts.freedesktop.org,
        Daniel Vetter <daniel@...ll.ch>, Wayne Lin <wayne.lin@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Srinivasan Shanmugam <srinivasan.shanmugam@....com>,
        David Airlie <airlied@...il.com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH] Revert "drm/amd/display: Check all enabled planes in
 dm_check_crtc_cursor"

On 10/2/23 12:05, Michel Dänzer wrote:
> On 9/29/23 22:41, Hamza Mahfooz wrote:
>> From: Ivan Lipski <ivlipski@....com>
>>
>> This reverts commit 45e1ade04b4d60fe5df859076005779f27c4c9be.
>>
>> Since, it causes the following IGT tests to fail:
>> kms_cursor_legacy@...sor-vs-flip.*
>> kms_cursor_legacy@...p-vs-cursor.*
> 
> Any information about how those tests fail? Maybe they accidentally rely on the broken behaviour?

I was able to reproduce, that doesn't seem to be the case. They just rely on multiple legacy cursor ioctl calls being able to complete between consecutive flips, which I suppose is broken by always pulling in non-cursor plane state with any cursor plane state changes.

I'll see if I can find a better solution. Meanwhile,

Acked-by: Michel Dänzer <mdaenzer@...hat.com>

for the revert.


-- 
Earthling Michel Dänzer            |                  https://redhat.com
Libre software enthusiast          |         Mesa and Xwayland developer